Skip to content

ci: run pull request CI on ready_for_review and draft PRs#896

Merged
yangxk1 merged 2 commits intoapache:mainfrom
Sober7135:893-ready-for-review-trigger
Mar 2, 2026
Merged

ci: run pull request CI on ready_for_review and draft PRs#896
yangxk1 merged 2 commits intoapache:mainfrom
Sober7135:893-ready-for-review-trigger

Conversation

@Sober7135
Copy link
Contributor

@Sober7135 Sober7135 commented Mar 1, 2026

Reason for this PR

fix #893 and part of #686

What changes are included in this PR?

  1. fix GitHub Actions are not triggered when draft PR changes to ready for view #893: CI should run when a draft PR is promoted to ready_for_review
  2. part of feat(ci): allow running CI when PR is draft or forked repo #686: CI should also be allowed to run on draft PRs

Are these changes tested?

Not yet. This PR is a test XD yes

Are there any user-facing changes?

No

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.83%. Comparing base (d535a43) to head (d8425bf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #896      +/-   ##
============================================
- Coverage     79.81%   76.83%   -2.99%     
  Complexity      615      615              
============================================
  Files            93       84       -9     
  Lines         10296     8897    -1399     
  Branches       1055     1055              
============================================
- Hits           8218     6836    -1382     
+ Misses         1838     1821      -17     
  Partials        240      240              
Flag Coverage Δ
cpp 70.89% <ø> (+0.09%) ⬆️
spark 81.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sober7135 Sober7135 marked this pull request as ready for review March 1, 2026 17:27
@Sober7135
Copy link
Contributor Author

Sober7135 commented Mar 1, 2026

emmm, it seems that marking PR as ready_for_review will retrigger CI. Maybe we should avoid this ? CC @yangxk1

@Sober7135 Sober7135 requested a review from yangxk1 March 1, 2026 17:33
@yangxk1
Copy link
Contributor

yangxk1 commented Mar 2, 2026

emmm, it seems that marking PR as ready_for_review will retrigger CI. Maybe we should avoid this ? CC @yangxk1

I think this is as expected

@Sober7135
Copy link
Contributor Author

emmm, it seems that marking PR as ready_for_review will retrigger CI. Maybe we should avoid this ? CC @yangxk1

I think this is as expected

Maybe running CI for draft PRs is enough?
Currently, draft PRs are already allowed to run CI. However, when the author marks the PR as ready_for_review, CI is triggered again by the ready_for_review event.

@yangxk1
Copy link
Contributor

yangxk1 commented Mar 2, 2026

If there are changes after ready_for_review, I'm afraid it's not enough to just run it in draft.

@Sober7135 Sober7135 marked this pull request as draft March 2, 2026 12:05
@Sober7135 Sober7135 marked this pull request as ready for review March 2, 2026 12:21
@Sober7135 Sober7135 requested a review from yangxk1 March 2, 2026 12:22
@yangxk1 yangxk1 merged commit 163123f into apache:main Mar 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Actions are not triggered when draft PR changes to ready for view

3 participants