KAFKA-20173: Propagate headers into serde 7/N#21851
Open
UladzislauBlok wants to merge 7 commits intoapache:trunkfrom
Open
KAFKA-20173: Propagate headers into serde 7/N#21851UladzislauBlok wants to merge 7 commits intoapache:trunkfrom
UladzislauBlok wants to merge 7 commits intoapache:trunkfrom
Conversation
...che/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java
Show resolved
Hide resolved
...che/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java
Outdated
Show resolved
Hide resolved
.../apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java
Show resolved
Hide resolved
UladzislauBlok
commented
Mar 22, 2026
Comment on lines
27
to
29
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.is; | ||
| import static org.hamcrest.Matchers.notNullValue; |
Contributor
Author
There was a problem hiding this comment.
@mjsax Do we use org.hamcrest? I thought AssertJ was chosen for KS.... Well never asked that, but had an assumption :)
aliehsaeedii
approved these changes
Mar 24, 2026
Contributor
aliehsaeedii
left a comment
aliehsaeedii
left a comment
There was a problem hiding this comment.
Thanks @UladzislauBlok. LGTM, just a question: Is there tracking for which places still need updating?
Contributor
aliehsaeedii
left a comment
aliehsaeedii
left a comment
There was a problem hiding this comment.
Thanks @UladzislauBlok. LGTM!
I only see that (unlike #21851), no tests verify that actual header data is propagated.
Contributor
Author
Hello, you have two summary comments for this PR and link is pointing to PR itself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures headers are propagated in
SubscriptionResponseWrapperSerde,LeftOrRightValueSerializer/DeserializerandTimestampedKeyAndJoinSideSerializer/DeserializerAdded unit tests to check headers propagation