KAFKA-20323: Refactor deleteRecords stub to use partition-based matching for Mockito upgrade#21857
Open
ChoMinGi wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20323: Refactor deleteRecords stub to use partition-based matching for Mockito upgrade#21857ChoMinGi wants to merge 1 commit intoapache:trunkfrom
ChoMinGi wants to merge 1 commit intoapache:trunkfrom
Conversation
…ing for Mockito upgrade - Change deleteRecords stubs from offset-based to partition-based matching - Upgrade Mockito from 5.20.0 to 5.23.0
github-actions
bot
added
triage
nileshkumar3
approved these changes
Mar 24, 2026
Contributor
nileshkumar3
left a comment
nileshkumar3
left a comment
There was a problem hiding this comment.
LGTM. Partition + anyLong() matches the real intent (tp1 succeeds, tp2 fails) and avoids relying on Mockito’s default for unstubbed CompletableFuture return types after 5.21+. The failure mode (second prune uses new offsets 11/21, so offset-only stubs no longer matched) is clear.
Author
|
@nileshkumar3 Thanks for the review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testRecordPruningTaskPeriodicityWithSomeFailuresfails with Mockito 5.21+ becauseunstubbed
CompletableFuturemethods now returncompletedFuture(null)instead ofnull, so unstubbeddeleteRecordscalls succeed instead of being no-ops.Changed
deleteRecordsstubs from offset-based matching to partition-based matching, which better reflects the test intent (tp1 succeeds, tp2 fails) and removes dependency on Mockito's default return behavior.Upgraded Mockito from 5.20.0 to 5.23.0 as the issue description allows 5.21.0 or more recent versions.
Verified locally that both 5.21.0 and 5.23.0 pass all
ShareCoordinatorServiceTesttests.