Skip to content

kafka - 19409: Upgrade RocksDB to 10.5.1 #21863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepgolani4 wants to merge 3 commits into
base: trunk
Choose a base branch
from
+22 −7
Open

kafka - 19409: Upgrade RocksDB to 10.5.1 #21863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecf2043
feat: Upgrade RocksDB to 10.5.1 and deprecate options that are remove…
deepgolani4 Mar 25, 2026
9663d71
Update RocksDB adapter deprecation since tags from 4.2 to 4.4
deepgolani4 Mar 25, 2026
810785f
added correct rocksDB version
deepgolani4 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE-binary
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ License Version 2.0:
- metrics-core-2.2.0
- opentelemetry-proto-1.3.2-alpha
- plexus-utils-3.6.0
- rocksdbjni-10.1.3
- rocksdbjni-10.5.1
- scala-library-2.13.18
- scala-logging_2.13-3.9.6
- scala-reflect-2.13.18
Expand Down
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ versions += [
protobuf: "3.25.5", // a dependency of opentelemetryProto
pcollections: "4.0.2",
re2j: "1.8",
rocksDB: "10.1.3",
rocksDB: "10.5.1",
// When updating the scalafmt version please also update the version field in checkstyle/.scalafmt.conf. scalafmt now
// has the version field as mandatory in its configuration, see
// https://github.com/scalameta/scalafmt/releases/tag/v3.1.0.
Expand Down
25 changes: 20 additions & 5 deletions ...a/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,13 +743,19 @@ public Cache rowCache() {
}

@Override
@Deprecated(since = "4.4", forRemoval = true)
public Options setFailIfOptionsFileError(final boolean failIfOptionsFileError) {
log.warn("fail_if_options_file_error no longer changes behavior in RocksDB v10.2.1 and later." +
" See https://github.com/facebook/rocksdb/releases/tag/v10.2.1");
dbOptions.setFailIfOptionsFileError(failIfOptionsFileError);
return this;
}

@Override
@Deprecated(since = "4.4", forRemoval = true)
public boolean failIfOptionsFileError() {
log.warn("fail_if_options_file_error no longer changes behavior in RocksDB v10.2.1 and later." +
" See https://github.com/facebook/rocksdb/releases/tag/v10.2.1");
return dbOptions.failIfOptionsFileError();
}

Expand Down Expand Up @@ -1236,15 +1242,18 @@ public boolean paranoidFileChecks() {
return columnFamilyOptions.paranoidFileChecks();
}

@Override
public Options setMaxWriteBufferNumberToMaintain(final int maxWriteBufferNumberToMaintain) {
columnFamilyOptions.setMaxWriteBufferNumberToMaintain(maxWriteBufferNumberToMaintain);
@Deprecated(since = "4.4", forRemoval = true)
public Options setMaxWriteBufferNumberToMaintain(final int ignored) {
log.warn("max_write_buffer_number_to_maintain has been removed in RocksDB v10.2.1" +
" See https://github.com/facebook/rocksdb/releases/tag/v10.2.1");
return this;
}

@Override
@Deprecated(since = "4.4", forRemoval = true)
public int maxWriteBufferNumberToMaintain() {
return columnFamilyOptions.maxWriteBufferNumberToMaintain();
log.warn("max_write_buffer_number_to_maintain has been removed in RocksDB v10.2.1" +
" See https://github.com/facebook/rocksdb/releases/tag/v10.2.1");
return 0;
}

@Override
Expand Down Expand Up @@ -1412,13 +1421,19 @@ public boolean unorderedWrite() {
}

@Override
@Deprecated(since = "4.4", forRemoval = true)
public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean skipCheckingSstFileSizesOnDbOpen) {
log.warn("skip_checking_sst_file_sizes_on_db_open has been deprecated in RocksDB v10.5.1" +
" See https://github.com/facebook/rocksdb/releases/tag/v10.5.1");
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
return this;
}

@Override
@Deprecated(since = "4.4", forRemoval = true)
public boolean skipCheckingSstFileSizesOnDbOpen() {
log.warn("skip_checking_sst_file_sizes_on_db_open has been deprecated in RocksDB v10.5.1" +
" See https://github.com/facebook/rocksdb/releases/tag/v10.5.1");
return dbOptions.skipCheckingSstFileSizesOnDbOpen();
}

Expand Down