Skip to content

KAFKA-20361 : Fix LazyDownConversionRecordsTest in using zlib-ng #21881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muralibasani wants to merge 1 commit into
base: 3.9
Choose a base branch
from
+2 −1
Open

KAFKA-20361 : Fix LazyDownConversionRecordsTest in using zlib-ng #21881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ private static MemoryRecords convertRecords(MemoryRecords recordsToConvert, byte
ByteBuffer convertedRecordsBuffer;
try (TransferableChannel channel = toTransferableChannel(FileChannel.open(outputFile.toPath(), StandardOpenOption.READ, StandardOpenOption.WRITE))) {
int written = 0;
while (written < bytesToConvert) written += lazySend.writeTo(channel, written, bytesToConvert - written);
// Use bytesToConvert as remaining to avoid truncating batches when V1 is larger than V2 (e.g. zlib-ng)
while (written < bytesToConvert) written += lazySend.writeTo(channel, written, bytesToConvert);
try (FileRecords convertedRecords = FileRecords.open(outputFile, true, written, false)) {
convertedRecordsBuffer = ByteBuffer.allocate(convertedRecords.sizeInBytes());
convertedRecords.readInto(convertedRecordsBuffer, 0);
Expand Down