Skip to content

fix: insecure default behavior in SslClientAuth.forConfig #21888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zendy199x wants to merge 1 commit into
base: trunk
Choose a base branch
from
+2 −2
Open

fix: insecure default behavior in SslClientAuth.forConfig #21888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/src/main/java/org/apache/kafka/common/config/SslClientAuth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ public enum SslClientAuth {

public static SslClientAuth forConfig(String key) {
if (key == null) {
return SslClientAuth.NONE;
return null;
}
String upperCaseKey = key.toUpperCase(Locale.ROOT);
for (SslClientAuth auth : VALUES) {
if (auth.name().equals(upperCaseKey)) {
return auth;
}
}
return null;
return SslClientAuth.NONE;
}

@Override
Expand Down