[KARAF-7437] Improve DOSGi exported interface property parsing#84
Open
CMoH wants to merge 2 commits intoapache:mainfrom
Open
[KARAF-7437] Improve DOSGi exported interface property parsing#84CMoH wants to merge 2 commits intoapache:mainfrom
CMoH wants to merge 2 commits intoapache:mainfrom
Conversation
CMoH
force-pushed
the
karaf-7437_service-exported-interfaces-type-fix
branch
from
a025231 to
8b5ceac
Compare
Match with OSGI R7 specs section 100.2
The OSGi annotations for DS and CDI expose the service.exported.interfaces typed as Class[]. Account for this value type when parsing this property in Karaf Cellar
CMoH
force-pushed
the
karaf-7437_service-exported-interfaces-type-fix
branch
from
f3d0ab1 to
4047d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I explained the problem in detail in the Jira issue.
As far as the patch goes, I have not found through a brief inspection any relevant tests to update/create. Maybe you can point me in that direction - even if the change seems trivial.
Looking forward to your comments.