Replace deprecated Plexus WriterFactory usage in MavenProjectInput#444
Replace deprecated Plexus WriterFactory usage in MavenProjectInput#444anukalp2804 wants to merge 6 commits intoapache:masterfrom
Conversation
| try (Writer writer = new OutputStreamWriter(output, StandardCharsets.UTF_8)) { | ||
| new MavenXpp3Writer().write(writer, prototype); | ||
|
|
||
| // normalize env specifics |
There was a problem hiding this comment.
we should really get rid of MavenXpp3Writer in the same PR since they're tied together
There was a problem hiding this comment.
Thanks for the review.
I’ve updated the code to write directly to the output stream and replaced MavenXpp3Writer, so both deprecations are addressed together as suggested.
anukalp2804
force-pushed
the
replace-deprecated-plexus-writer
branch
from
00b4c01 to
d9637f1
Compare
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
you might need to push, I don't see these changes made
|
Thank you — I’ve pushed the updated changes now. Please let me know if any further changes are needed. |
|
Hi, just checking in — this PR was approved earlier. Please let me know if anything else is needed from my side before it can be merged. Thanks! |
1 similar comment
|
Hi, just checking in — this PR was approved earlier. Please let me know if anything else is needed from my side before it can be merged. Thanks! |
|
tests are failing on JDK 17 |
Thanks for the feedback — I’m investigating the JDK 17 test failures and will update shortly. |
anukalp2804
force-pushed
the
replace-deprecated-plexus-writer
branch
from
eb8d6e9 to
1a02f83
Compare
|
Updated to use UTF-8 encoding via charset name to ensure consistent behavior and fix JDK 17 test failures. |
|
Hi, I have updated the JDK 17 test failures. Please let me know if anything else is needed from my side Thank you |
|
Solve the format violations. I hope this will correct. |
anukalp2804
force-pushed
the
replace-deprecated-plexus-writer
branch
from
e056988 to
f489889
Compare
|
updated code. |
2 participants
This PR addresses one of the deprecations reported in #436 by replacing the deprecated plexus-utils
WriterFactory.newXmlWriter(...)usage inMavenProjectInputwith an equivalent JDK-based writer.The change is intentionally small and self-contained, and does not alter behavior.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.