Skip to content

MINIFICPP-2722 C API enum explicit type#2111

Open
martinzink wants to merge 1 commit intoapache:mainfrom
martinzink:MINIFICPP-2722
Open

MINIFICPP-2722 C API enum explicit type#2111
martinzink wants to merge 1 commit intoapache:mainfrom
martinzink:MINIFICPP-2722

Conversation

@martinzink
Copy link
Member

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink added this to the minifi-rust milestone Feb 18, 2026
@martinzink martinzink added the low-impact Test only or trivial change that's most likely not gonna introduce any new bugs label Feb 18, 2026
@martinzink martinzink requested a review from Copilot February 18, 2026 10:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds explicit uint32_t underlying types to all enum definitions in the MiNiFi C API header file. The change ensures that all enums have a guaranteed size and representation, which is important for ABI stability and interoperability.

Changes:

  • Added explicit uint32_t type specifier to 4 enum definitions: MinifiInputRequirement, MinifiStatus, MinifiValidator, and MinifiLogLevel

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-impact Test only or trivial change that's most likely not gonna introduce any new bugs ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments