Skip to content

feat: add reqsign release skill#731

Open
Xuanwo wants to merge 1 commit intomainfrom
xuanwo/reqsign-release-skill
Open

feat: add reqsign release skill#731
Xuanwo wants to merge 1 commit intomainfrom
xuanwo/reqsign-release-skill

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 23, 2026

This adds a repo-local reqsign-release skill so release preparation and execution can be driven from a single self-contained workflow instead of relying on personal notes.

It captures the opendal-reqsign specific release sequence, GitHub Discussion templates, ASF dist/SVN conventions, and final cargo publish --workspace behavior. It also records the recent .sha512 path pitfall so future release candidates generate portable checksum files.

Comment on lines +232 to +236
## Round 2 and Repairs

- If the tarball, signature, tag, or any release content changes after voting starts, prefer a new RC tag and a new vote round.
- If only the `.sha512` sidecar file is malformed and the user explicitly wants an in-place fix, update only that checksum file in `dist/dev`, verify `shasum -c`, and comment in the VOTE thread that the tarball and signature are unchanged.
- In-place checksum repair is weaker than issuing `rc.N+1`. Call out that tradeoff explicitly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any release artifact under vote needs to change, prefer cutting a new RC and restarting the vote.
For a malformed checksum sidecar, in-place repair should be treated only as an exceptional project decision, not the default release procedure. 🤔


https://github.com/apache/opendal-reqsign/releases/tag/vX.Y.Z-rc.N

Please download, verify, and test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we also add a verify script in the repo(attach link here)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agents know how to verify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although agents know how to verify, but with a verify script or some verify guideline is more friendly for human voter, and make verify process more reproducible.
I'm not sure about how you use agents in the verify process, but I'm sure we should not rely on implicit agents behavior.

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be a bit more careful with this PR, especially since it defines part of our release process.


https://github.com/apache/opendal-reqsign/releases/tag/vX.Y.Z-rc.N

Please download, verify, and test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although agents know how to verify, but with a verify script or some verify guideline is more friendly for human voter, and make verify process more reproducible.
I'm not sure about how you use agents in the verify process, but I'm sure we should not rely on implicit agents behavior.

Comment on lines +232 to +236
## Round 2 and Repairs

- If the tarball, signature, tag, or any release content changes after voting starts, prefer a new RC tag and a new vote round.
- If only the `.sha512` sidecar file is malformed and the user explicitly wants an in-place fix, update only that checksum file in `dist/dev`, verify `shasum -c`, and comment in the VOTE thread that the tarball and signature are unchanged.
- In-place checksum repair is weaker than issuing `rc.N+1`. Call out that tradeoff explicitly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any release artifact under vote needs to change, prefer cutting a new RC and restarting the vote.
For a malformed checksum sidecar, in-place repair should be treated only as an exceptional project decision, not the default release procedure. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants