feat(services/s3): Add a way to specify a default object ACL #7186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default ACL is used when creating an object. apache#5358 Note: I did not use a fixed list for the ACL but a String since I'm not an expert on this, and I don't really know if, for all supported services, we can restrict it the list of [canned ACL](https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html#canned-acl).
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default ACL is used when creating an object.
Note: I did not use a fixed list for the ACL but a String since I'm not an expert on this, and I don't really know if, for all supported services, we can restrict it the list of canned ACL.
Also note that not all s3 providers support those ACL. Amazon does, OVH also, but not minio for example (cf issue)/
I did not add any tests, as I don't really see test specific for s3 and also because minio, used in the tests do not support this.
I only tested this manually (using the python bindings, since this is what I will use), and the objects created have the right ACL. I can add tests if needed and if someone can point me how to add those.
Which issue does this PR close?
Closes #5358
Rationale for this change
Even if ACL are deprecated, they can be handy in many situations.
Are there any user-facing changes?
This adds a
default_acloption while configuring a s3 operator. This ACL is used when creating a new object.AI Usage Statement
I did not use any AI to code this.