【ISSUE #133】RocketMQ-Operator support the rocketmq-5.0 proxy node for cluster pattern#134
Open
shendongsd wants to merge 6 commits intoapache:masterfrom
Open
【ISSUE #133】RocketMQ-Operator support the rocketmq-5.0 proxy node for cluster pattern#134shendongsd wants to merge 6 commits intoapache:masterfrom
shendongsd wants to merge 6 commits intoapache:masterfrom
Conversation
added 4 commits
October 10, 2022 09:25
…q-operator into feature_proxy
caigy
requested changes
Oct 18, 2022
Contributor
caigy
left a comment
caigy
left a comment
There was a problem hiding this comment.
It seems that ClusterRole for proxy is missing.
| // INSERT ADDITIONAL SPEC FIELDS - desired state of cluster | ||
| // Important: Run "operator-sdk generate k8s" to regenerate code after modifying this file | ||
| // Add custom validation using kubebuilder tags: https://book-v1.book.kubebuilder.io/beyond_basics/generating_crd.html | ||
| ProxyStatefulSet v1.StatefulSet `json:"proxyStatefulSet"` |
Contributor
There was a problem hiding this comment.
Proxy is stateless, so is deployment more appropriate than statefulset?
Furthermore, it would be more elegant that users should only provide configs which they care about, instead of providing the whole statefulset or deployment.
|
How is it going? Can you merge it? @shendongsd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ISSUE #133RocketMQ-Operator support the rocketmq-5.0 proxy node for cluster pattern
And I will add local pattern later