[SEDONA-751] RS_Interpolate band index and noDataValue handling#2958
Open
prantogg wants to merge 1 commit into
Open
[SEDONA-751] RS_Interpolate band index and noDataValue handling#2958prantogg wants to merge 1 commit into
prantogg wants to merge 1 commit into
Conversation
b518f88 to
3a9890f
Compare
3a9890f to
71111c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Fixes two bugs in
RS_Interpolate:Band index bug: When interpolating a specific band in a multi-band raster, non-interpolated bands were copied using the wrong index variable (
bandinstead ofbandIndex), causing incorrect data in the output raster.noDataValue NaN comparison bug: When
noDataValueisNaN, the comparisoninterpolatedValue != noDataValuealways returnstrue(sinceNaN != NaNin IEEE 754), causingcountNoDataValuesto be incorrectly decremented even when interpolation didn't produce a valid value. Fixed by using properDouble.isNaN()checks.How was this patch tested?
Added
testInterpolatePreservesOtherBandstest that creates a 2-band raster, interpolates only band 1, and verifies band 2 is preserved unchanged. Existing interpolation tests continue to pass.Did this PR include necessary documentation updates?