[SEDONA-752] fix: NullPointerException from deep traversal beyond GeoJSON geometry level#2959
Open
prantogg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
The GeoJSON reader's
convertGeoJsonToGeometryandupdateGeometrySchemamethods were recursing into all nested StructType fields unconditionally. When a GeoJSON feature had nested struct properties (e.g.,properties.prop1.nested_field), the traversal would descend into those property-level structs looking for a "geometry" field to convert. If any such struct happened to have fields that didn't match expected geometry patterns, this caused a NullPointerException.This PR fixes the issue by:
hasGeometryFieldhelper that detects whether the current struct level contains a "geometry" fieldupdateGeometrySchemawith the same bounded-recursion logic so schema updates stop at the first geometry levelHow was this patch tested?
geojson_feature-collection.jsontest fixture to include nested struct properties (with multiple levels of nesting) that previously triggered the NPEupdateGeometrySchema should update first geometry struct onlythat verifies schema traversal stops at the first geometry level and does not modify deeper "geometry" fields in property structsDid this PR include necessary documentation updates?