-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-58082][SQL] Add DSv2 relation and row-level command tree patterns #57178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yyanyy
wants to merge
2
commits into
apache:master
Choose a base branch
from
yyanyy:spark-dsv2-tree-patterns-20260708
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
...rc/test/scala/org/apache/spark/sql/catalyst/plans/logical/V2CommandTreePatternSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.catalyst.plans.logical | ||
|
|
||
| import java.util | ||
|
|
||
| import org.apache.spark.SparkFunSuite | ||
| import org.apache.spark.sql.catalyst.ProjectingInternalRow | ||
| import org.apache.spark.sql.catalyst.dsl.expressions._ | ||
| import org.apache.spark.sql.catalyst.expressions.Literal | ||
| import org.apache.spark.sql.catalyst.trees.TreePattern | ||
| import org.apache.spark.sql.catalyst.util.{ReplaceDataProjections, WriteDeltaProjections} | ||
| import org.apache.spark.sql.connector.catalog.{Column, Table, TableCapability} | ||
| import org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation | ||
| import org.apache.spark.sql.types.{IntegerType, StructType} | ||
| import org.apache.spark.sql.util.CaseInsensitiveStringMap | ||
|
|
||
| /** | ||
| * Pins the tree-pattern identity contract for the DSv2 row-level command nodes: each node carries | ||
| * both the shared `COMMAND` bit and its own identity bit, so rules can prune on either. | ||
| */ | ||
| class V2CommandTreePatternSuite extends SparkFunSuite { | ||
|
|
||
| private val target = LocalRelation($"a".int, $"b".int) | ||
| private val source = LocalRelation($"c".int, $"d".int) | ||
|
|
||
| // A minimal `NamedRelation` for the row-level write nodes, whose `nodePatternsInternal()` | ||
| // returns a compile-time constant, so no resolution is needed to pin the identity bit. | ||
| private val v2Relation: DataSourceV2Relation = { | ||
| val table = new Table { | ||
| override def name(): String = "t" | ||
| override def columns(): Array[Column] = Array(Column.create("a", IntegerType)) | ||
| override def capabilities(): util.Set[TableCapability] = util.Set.of[TableCapability]() | ||
| } | ||
| DataSourceV2Relation.create(table, None, None, CaseInsensitiveStringMap.empty()) | ||
| } | ||
|
|
||
| private val emptyRow = ProjectingInternalRow(new StructType(), IndexedSeq.empty) | ||
|
|
||
| test("DeleteFromTable declares COMMAND and DELETE_FROM_TABLE") { | ||
| val plan = DeleteFromTable(target, Literal.TrueLiteral) | ||
| assert(plan.containsAllPatterns(TreePattern.COMMAND, TreePattern.DELETE_FROM_TABLE)) | ||
| } | ||
|
|
||
| test("UpdateTable declares COMMAND and UPDATE_TABLE") { | ||
| val plan = UpdateTable(target, Seq.empty, Some(Literal.TrueLiteral)) | ||
| assert(plan.containsAllPatterns(TreePattern.COMMAND, TreePattern.UPDATE_TABLE)) | ||
| } | ||
|
|
||
| test("MergeIntoTable declares COMMAND and MERGE_INTO_TABLE") { | ||
| val plan = MergeIntoTable( | ||
| target, | ||
| source, | ||
| mergeCondition = $"a" === $"c", | ||
| matchedActions = Seq(DeleteAction(None)), | ||
| notMatchedActions = Seq(InsertAction(None, | ||
| Seq(Assignment($"a", $"c"), Assignment($"b", $"d")))), | ||
| notMatchedBySourceActions = Seq(DeleteAction(None)), | ||
| withSchemaEvolution = false) | ||
| assert(plan.containsAllPatterns(TreePattern.COMMAND, TreePattern.MERGE_INTO_TABLE)) | ||
| } | ||
|
|
||
| test("ReplaceData declares COMMAND and REPLACE_DATA") { | ||
| val plan = ReplaceData( | ||
| v2Relation, | ||
| Literal.TrueLiteral, | ||
| source, | ||
| v2Relation, | ||
| ReplaceDataProjections(emptyRow, None)) | ||
| assert(plan.containsAllPatterns(TreePattern.COMMAND, TreePattern.REPLACE_DATA)) | ||
| } | ||
|
|
||
| test("WriteDelta declares COMMAND and WRITE_DELTA") { | ||
| val plan = WriteDelta( | ||
| v2Relation, | ||
| Literal.TrueLiteral, | ||
| source, | ||
| v2Relation, | ||
| WriteDeltaProjections(None, emptyRow, None)) | ||
| assert(plan.containsAllPatterns(TreePattern.COMMAND, TreePattern.WRITE_DELTA)) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suite pins the
COMMAND+ identity-bit contract for 3 of the 5 command nodes the PR touches —ReplaceDataandWriteDeltaare missing. TheirREPLACE_DATA/WRITE_DELTAbits are the most load-bearing in the PR:GroupBasedRowLevelOperationScanPlanning,OptimizeMetadataOnlyDeleteFromTable, andRowLevelOperationRuntimeGroupFilteringall prune exclusively on them, so a wrong bit there would silently disable those rules with no unit-level signal. Worth adding two cases here; thenodePatternsInternal()overrides return compile-time constants, so a minimal instance pins the bit without needing resolution.(Relatedly, the PR description's "asserts each command node carries both
COMMANDand its own bit" reads as all five — worth adjusting to match the actual coverage.)