Skip to content

fix(a11y): WCAG 1.4.3 — enforce accessible link color contrast #39234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aitema-gmbh wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −0
Open

fix(a11y): WCAG 1.4.3 — enforce accessible link color contrast #39234

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4859f1a
fix(a11y): WCAG 1.4.3 — enforce accessible link color contrast (#0d70…
Apr 9, 2026
4793676
fix(a11y): WCAG 1.4.3 — use theme tokens instead of hardcoded link co…
Apr 17, 2026
efcc335
fix(a11y): WCAG 1.4.3 — collapse redundant link selectors, clarify scope
May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions superset-frontend/packages/superset-core/src/theme/GlobalStyles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,20 @@ export const GlobalStyles = () => {
font-family: ${theme.fontFamily};
}

/* WCAG 1.4.3: Minimum Contrast — route link colors through theme
tokens so they adapt to light, dark, and custom themes. Buttons
rendered as `<a class="ant-btn ...">` or `role="button"` carry
their own component-level coloring and override these values, so
a single global rule is enough; the previous duplicated selector
had no effect over the simple `a` rule. The 4.5:1 contrast
guarantee depends on the active theme's `colorLink` /
`colorLinkHover` tokens being tuned for the paired `colorBgBase`. */
a {
color: ${theme.colorLink};
}
a:hover {
color: ${theme.colorLinkHover};
}

h1,
h2,
Expand Down
Loading