Skip to content

fix(a11y): WCAG 3.1.2 — set HTML lang attribute dynamically from locale #39243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 2 commits into from
Apr 20, 2026
+8 −0
Merged

fix(a11y): WCAG 3.1.2 — set HTML lang attribute dynamically from locale #39243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41410f6
fix(a11y): WCAG 3.1.2 — set HTML lang attribute dynamically from loca…
Apr 9, 2026
1317b53
fix(a11y): WCAG 3.1.2 — normalize locale to BCP-47 instead of strippi…
Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions superset-frontend/src/views/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ setupAGGridModules();

const bootstrapData = getBootstrapData();

// WCAG 3.1.2: Set the HTML lang attribute based on the current locale
// so screen readers announce the correct language for the page content.
// Normalize to BCP-47 format by replacing underscores with hyphens
// so region subtags like "pt_BR" become valid "pt-BR" rather than being dropped.
const locale =
bootstrapData.common?.locale || window.navigator.language || 'en';
document.documentElement.lang = String(locale).replace(/_/g, '-');

let lastLocationPathname: string;

const boundActions = bindActionCreators({ logEvent }, store.dispatch);
Expand Down
Loading