Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ fastmcp = [
# heuristic that under-counts JSON-heavy MCP responses.
"tiktoken>=0.7.0,<1.0",
]
firebird = ["sqlalchemy-firebird>=0.7.0, <0.8"]
firebird = ["sqlalchemy-firebird>=0.7.0, <2.2"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version Constraint Inconsistency

The version constraint for sqlalchemy-firebird in pyproject.toml has been updated to allow versions up to <2.2, but the corresponding version_requirements in the FirebirdEngineSpec metadata still restricts to <0.8. This inconsistency could confuse users or cause display issues in the UI/docs, as the spec is used for compatibility info. Please update the engine spec to match.

Code suggestion
Check the AI-generated fix before applying
 -        "version_requirements": "sqlalchemy-firebird>=0.7.0,<0.8",
 +        "version_requirements": "sqlalchemy-firebird>=0.7.0,<2.2",

Code Review Run #898ac4


Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

firebolt = ["firebolt-sqlalchemy>=1.0.0, <2"]
gevent = ["gevent>=23.9.1"]
gsheets = ["shillelagh[gsheetsapi]>=1.4.4, <2"]
Expand Down
Loading