fix(mcp): exclude self-referencing filter columns from get_schema output by eschutho · Pull Request #39826 · apache/superset

eschutho · 2026-05-01T23:11:04Z

SUMMARY

Regression from #39638: get_schema(model_type='chart|dataset|dashboard') still advertised created_by_fk and owner in filter_columns because the chart, dataset, and dashboard ModelGetSchemaCore instances had no exclude_filter_columns set.

The LLM workflow that triggered the bug:

LLM calls get_schema(model_type='chart') to discover available filter columns
Response includes created_by_fk in filter_columns
LLM calls get_instance_info to get current_user.id
LLM calls list_charts(request={"filters": [{"col": "created_by_fk", "opr": "eq", "value": 13}]})

This bypasses the created_by_me/owned_by_me server-side injection added in #39638, re-exposing user IDs in tool calls.

Fix: pass SELF_REFERENCING_FILTER_COLUMNS as exclude_filter_columns to the chart, dataset, and dashboard ModelGetSchemaCore instances. The database schema core already had its user-directory columns excluded via DATABASE_EXCLUDE_COLUMNS.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

pytest tests/unit_tests/mcp_service/system/tool/test_get_schema.py -q

Manually verify get_schema no longer advertises created_by_fk or owner:

result = await client.call_tool("get_schema", {"request": {"model_type": "chart"}})
# filter_columns should NOT contain "created_by_fk" or "owner"

ADDITIONAL INFORMATION

Fixes regression introduced by #39638.

After #39638, chart/dataset/dashboard ModelGetSchemaCore instances had no exclude_filter_columns set, so get_schema(model_type='chart|dataset|dashboard') still advertised created_by_fk and owner in filter_columns. LLMs would call get_schema to discover available filters, see those columns, and pass real user IDs directly — bypassing the created_by_me/owned_by_me server-side injection added in #39638. Pass SELF_REFERENCING_FILTER_COLUMNS as exclude_filter_columns for chart, dataset, and dashboard schema cores (the database core already excluded its user-directory columns via DATABASE_EXCLUDE_COLUMNS). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

bito-code-review · 2026-05-01T23:11:14Z

Code Review Agent Run #d63c60

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 373c366..373c366
- superset/mcp_service/system/tool/get_schema.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-05-01T23:15:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.89%. Comparing base (98eaaaa) to head (c0ef691).
⚠️ Report is 54 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #39826      +/-   ##
==========================================
- Coverage   64.37%   63.89%   -0.48%     
==========================================
  Files        2569     2583      +14     
  Lines      134682   136611    +1929     
  Branches    31253    31490     +237     
==========================================
+ Hits        86698    87285     +587     
- Misses      46485    47810    +1325     
- Partials     1499     1516      +17

Flag	Coverage Δ
hive	`39.38% <ø> (-0.30%)`	⬇️
mysql	`59.06% <ø> (-0.86%)`	⬇️
postgres	`59.13% <ø> (-0.86%)`	⬇️
presto	`41.08% <ø> (-0.35%)`	⬇️
python	`60.57% <ø> (-0.97%)`	⬇️
sqlite	`58.77% <ø> (-0.86%)`	⬇️
unit	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…d dataset The existing test only covered dashboard. Add parallel tests for chart and dataset to verify that created_by_fk, owner, and created_by_fk_or_owner are excluded from filter_columns even when the DAO returns them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

bito-code-review · 2026-05-02T00:48:53Z

Code Review Agent Run #c5edd6

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 373c366..f6ef071
- tests/unit_tests/mcp_service/system/tool/test_get_schema.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

aminghadersohi

The production change looks correct as defense-in-depth. Two concerns about the tests:

The mocks in test_get_schema_chart_omits_self_referencing_filter_columns and the dataset equivalent only return created_by_fk and owner, which are already excluded by USER_DIRECTORY_FIELDS in ModelGetSchemaCore.__init__ (unconditionally, via self.exclude_filter_columns.update(USER_DIRECTORY_FIELDS)) — these assertions pass even without this PR's fix. To actually exercise the new exclude_filter_columns behavior, include "created_by_fk_or_owner": ["eq"] in the mock return value and assert it's absent from the output. As written, reverting the production change would not cause any of the new tests to fail.
_get_dashboard_schema_core() receives the same exclude_filter_columns=set(SELF_REFERENCING_FILTER_COLUMNS) fix but has no corresponding test for self-referencing column exclusion.

Add `created_by_fk_or_owner` to the mock return values in the chart and dataset self-referencing filter tests so the exclusion is actually exercised (previously the assertion was vacuously true since the key was never in the mock). Also add a matching test for the dashboard schema core, which received the same exclude_filter_columns fix but had no corresponding coverage.

netlify · 2026-05-07T15:39:03Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`c0ef691`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/69fcb1bf065a4c0007244029
😎 Deploy Preview	https://deploy-preview-39826--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

bito-code-review · 2026-05-08T03:54:04Z

Code Review Agent Run #c78dd6

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: f6ef071..c0ef691
- tests/unit_tests/mcp_service/system/tool/test_get_schema.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size Bot added the size/XS label May 1, 2026

pull-request-size Bot added size/M and removed size/XS labels May 1, 2026

eschutho requested review from aminghadersohi and betodealmeida and removed request for betodealmeida May 4, 2026 23:55

aminghadersohi reviewed May 5, 2026

View reviewed changes

aminghadersohi approved these changes May 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(mcp): exclude self-referencing filter columns from get_schema output#39826

fix(mcp): exclude self-referencing filter columns from get_schema output#39826
eschutho wants to merge 3 commits intomasterfrom
fix/mcp-exclude-self-referencing-filter-columns-from-schema

eschutho commented May 1, 2026

Uh oh!

bito-code-review Bot commented May 1, 2026 •

edited

Loading

Code Review Agent Run #d63c60

Uh oh!

codecov Bot commented May 1, 2026 •

edited

Loading

Uh oh!

bito-code-review Bot commented May 2, 2026 •

edited

Loading

Code Review Agent Run #c5edd6

Uh oh!

aminghadersohi left a comment

Uh oh!

netlify Bot commented May 7, 2026

Uh oh!

bito-code-review Bot commented May 8, 2026 •

edited

Loading

Code Review Agent Run #c78dd6

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eschutho commented May 1, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #d63c60

Uh oh!

codecov Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bito-code-review Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c5edd6

Uh oh!

aminghadersohi left a comment

Choose a reason for hiding this comment

Uh oh!

netlify Bot commented May 7, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

bito-code-review Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c78dd6

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bito-code-review Bot commented May 1, 2026 •

edited

Loading

codecov Bot commented May 1, 2026 •

edited

Loading

bito-code-review Bot commented May 2, 2026 •

edited

Loading

bito-code-review Bot commented May 8, 2026 •

edited

Loading