This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7926 +/- ##
============================================
+ Coverage 29.09% 32.06% +2.97%
Complexity 98 98
============================================
Files 605 722 +117
Lines 77535 82925 +5390
Branches 90 970 +880
============================================
+ Hits 22558 26590 +4032
- Misses 52894 54183 +1289
- Partials 2083 2152 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d5e3019 to
870c26a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors
api.Handlersuch that the return type is a single error instead of a user-facing error, a system-facing error, and a status code. It then handles the error specially if it is anapi.Errorsimplementation. I also updated usage accordingly throughout the two endpoint handling packages that useapi.Wrap.Essentially this reduces
to
and
to
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
This is just a refactor; behavior should be unchanged and the existing tests should continue to pass.
PR submission checklist