GCP-431: feat: add network SA to HostedCluster template#60
Merged
apahim merged 1 commit intoapahim:mainfrom Apr 29, 2026
Merged
GCP-431: feat: add network SA to HostedCluster template#60apahim merged 1 commit intoapahim:mainfrom
apahim merged 1 commit intoapahim:mainfrom
Conversation
Include the cloud-network (CNCC) service account in the HostedCluster workloadIdentity serviceAccountsEmails configuration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkfield toserviceAccountsEmailsin HostedCluster templateContext
HyperShift PR openshift/hypershift#7824 added a required
networkfield toGCPServiceAccountsEmailsfor CNCC WIF authentication. The controller templatemust include this field when creating HostedCluster resources.
Dependencies
Jira