Expose serialization initializers#16
Open
Trickfest wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explicit public initializers for
FenSerializationandSanSerialization.ChessKit 2.0 removed the previous
.defaultserializer accessors, and the README now shows direct construction withFenSerialization(). Since these are public classes without explicit public initializers, Swift synthesizes internalinit()methods, which means downstream packages cannot currently instantiate them.I stumbled on this while trying to update ChessboardKit to use ChessKit 2.0. It needs to deserialize FEN into a
Game(position:)and serialize the current position back to FEN, butFenSerialization()was not accessible from outside the module.Nice job on ChessKit, btw! :-)
Changes
public init() {}toFenSerializationpublic init() {}toSanSerializationChessKitnormally and verifies both serializers can be constructed by downstream usersThis does not reintroduce
.defaultand does not change serialization behavior.Verification
swift test