Add proxy support for HTTPS_PROXY/https_proxy environment variables#5
Open
mkw wants to merge 1 commit intoapify:mainfrom
Open
Add proxy support for HTTPS_PROXY/https_proxy environment variables#5mkw wants to merge 1 commit intoapify:mainfrom
mkw wants to merge 1 commit intoapify:mainfrom
Conversation
Node.js native fetch (undici) does not respect proxy environment variables. This causes mcpc to fail in environments that route network traffic through an HTTP proxy, such as Claude Code's sandbox. This change: - Adds a createProxyAwareFetch() helper that detects proxy env vars and creates a fetch function using undici's ProxyAgent - Passes the proxy-aware fetch to StreamableHTTPClientTransport when proxy env vars are detected - Makes createStreamableHttpTransport and createTransportFromConfig async to support the dynamic import of undici - Adds undici as a direct dependency (required for ProxyAgent access) - Adds 5 new unit tests for proxy-aware fetch functionality - Updates existing tests to handle async transport creation Fixes apify#4 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https_proxy/HTTPS_PROXYenvironment variables and creates a proxy-aware fetch using undici'sProxyAgentProblem
Node.js native
fetch()(powered by undici) does not respect proxy environment variables. This causes mcpc to fail withgetaddrinfo ENOTFOUNDerrors in environments like Claude Code's sandbox, which routes all network traffic through a local HTTP proxy.Solution
When proxy environment variables are detected, create a custom fetch function using undici's
ProxyAgentand pass it to the MCP SDK'sStreamableHTTPClientTransport:Changes
package.jsonundicidependencysrc/core/transports.tscreateProxyAwareFetch(), made transport functions asyncsrc/core/factory.tsawaitfor async transport creationtest/unit/core/transports.test.tstest/unit/core/factory.test.tsTest plan
Fixes #4
🤖 Generated with Claude Code