#BE8480 - Workflow to Integration Updates#1179
Conversation
…ks and added redirects
✅ Deploy Preview for reverent-galileo-8ef035 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cagkanaksunyuksel
left a comment
There was a problem hiding this comment.
Please wait for my approval.
PR Review Comment — Conceptual Framework for "Workflow" vs "Integration"Before reviewing specific changes, it's worth establishing a clear definition for both terms — because this PR applies the rename too broadly in some places, and not broadly enough in others. Conceptual FrameworkBased on reviewing the current production docs and how Bitrise (a comparable platform) handles this distinction: Workflow → The container. A sequence of steps that defines how an app is built, executed top to bottom. This maps directly to the Workflow Editor, the pipeline structure, and the build configuration. This term should be kept wherever it refers to this concept.
Integration → A specific step that connects Appcircle to a third-party service (Firebase, Jira, Slack, BrowserStack, Testinium, etc.). The "Build Integrations" section is essentially the catalog of these connectors. This is where the original terminology problem lived — these were being documented as generic "workflow steps" when they are specifically third-party integrations.
Note: Not every step is an integration. Issues with the Current PR🔴 Over-replacement: "Workflow" removed where it should stayThe PR replaces "workflow" in contexts where it refers to the pipeline/container concept, which is incorrect. These should remain as "workflow": <!-- These are fine as-is — "workflow" here means the pipeline structure -->
...steps defined in the [workflow](/build-integrations)...
...use the below Custom Script as a replacement of the default Android Build step. Remove [...] steps from your workflow.
...the [workflow](/build-integrations) should also have an Install Certificates & Profiles step.The link target can point to /build-integrations for discoverability, but the anchor text should not contradict the concept. Or better, these inline [workflow] links should simply point back to the Workflow Editor docs, not to the integrations catalog. 🔴 Broken Redirect Targets in netlify.tomlMany to = values still carry old path segments, pointing to non-existent URLs: to = "/build-integrations/common-workflow-steps/custom-script"
# should be: /build-integrations/common-integrations/custom-script
to = "/build-integrations/android-specific-workflow-steps/android-sign"
# should be: /build-integrations/android-specific-integrations/android-sign
to = "/build-integrations/ios-specific-workflow-steps/firebase-upload-dsym"
# should be: /build-integrations/ios-specific-integrations/firebase-upload-dsymA full audit of all to = values in the redirect block is needed. 🟡 ContentRef Labels Not UpdatedURLs were updated but visible labels still say "Workflows": <ContentRef url="/build-integrations">What are Workflows and How to Use Them?</ContentRef>
<ContentRef url="/build-integrations/react-native-specific-integrations">React Native Specific Workflow Steps</ContentRef>If the destination page is now titled around "Integrations", the label should match. 🟡 Core Build Steps Mislabeled as IntegrationsSteps like Git Clone, Android Build, Export Build Artifacts, Select Java Version are not third-party integrations — they are native build steps. Grouping their documentation under "Build Integrations" flattens a meaningful distinction. Consider whether these belong under a separate "Build Steps" section or are explicitly called out as "core steps" vs "integrations" within the same section. RecommendationThe goal of this change — using "integration" where Appcircle connects to a third-party service — is correct. The execution needs two adjustments: Don't replace "workflow" where it refers to the pipeline structure. These are not the same concept and shouldn't point to the same destination. |
Updated workflows related URLs to build-integration. Fixed broken links and added redirects