fix: treat logically-deleted items as unknown parent in repair()#1
Open
LucasXu0 wants to merge 1 commit into
Open
fix: treat logically-deleted items as unknown parent in repair()#1LucasXu0 wants to merge 1 commit into
LucasXu0 wants to merge 1 commit into
Conversation
A logically-deleted item (is_deleted flag set) cannot serve as a parent branch. yjs handles this by evaluating content.type, which returns undefined for non-Type items (e.g. Format), silently dropping the child. yrs only checked ItemContent::Deleted (GC state) and missed the is_deleted() flag, causing a spurious InvalidParent error on documents containing deleted Format items as parent refs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A logically-deleted item (is_deleted flag set) cannot serve as a parent branch.