Fix missing await on generate() in ConstrainedGenerator#87
Merged
Conversation
stikves
force-pushed
the
fix/constrained-generator-await
branch
5 times, most recently
from
55a0c55 to
9c9a425
Compare
ConstrainedGenerator.decode() calls InferenceEngine.generate() which is async throws, but was missing the await keyword.
stikves
force-pushed
the
fix/constrained-generator-await
branch
from
9c9a425 to
411f935
Compare
tjia1818
approved these changes
Jul 6, 2026
Contributor
|
Thanks for the quick fix - also added this issue to make sure we can cover these in the future #88 |
carinapeng
approved these changes
Jul 6, 2026
Contributor
|
Shall we merge this soon? ToT main build is broken at the moment because of this :( |
Contributor
Author
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86.
ConstrainedGenerator.decode()callsInferenceEngine.generate()which isasync throws, but was missing theawaitkeyword — causing a compile error.