Update object detector input array creation to use span#93
Merged
Conversation
alejandro-isaza
approved these changes
Jul 9, 2026
tjia1818
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update buildInputNDArray to acquire the mutable view outside the preprocessing loop
This reworks ObjectDetector.buildInputNDArray to obtain the input NDArray's mutable storage once via mutableView(...).contiguousElements before the per-image loop, then index the resulting bounds-checked MutableSpan to write each image into its [3, H, W] batch slot.
This is safer because it drops the raw UnsafeMutablePointer arithmetic and baseAddress! force-unwrap, and treats a non-contiguous buffer (where contiguousElements is nil) as an explicit error instead of silently mis-indexing. Behavior is unchanged — each image still lands in its correct batch slot with no B3H*W intermediate buffer.