fix linear_to_conv2d_map to work with other distilbert model types#4
fix linear_to_conv2d_map to work with other distilbert model types#4anentropic wants to merge 2 commits intoapple:mainfrom
Conversation
181a16d to
ee34e9c
Compare
|
Hi @anentropic thanks for the patch! I tried it on DistilBertForMaskedLM, and managed to successfully produce an optimized model with this code However, the mlpackage produced seems to result in the wrong dimensionality outputs: comparing the baseline and optimized models on Netron shows this difference. Moreover, I am unable to performance test the new mlpackage on XCode. Do you know what may be missing? |
|
@angusfong I don't know off the top of my head and it's a while since I looked at it unfortunately I do remember I ended up making some more fixes and refactoring, I didn't bother to make another PR here since there doesn't seem to be anybody handling public contributions to this repo actually... reading through my altered code now it does look like I may have encountered the same problem, I commented something in |


re #3 (comment)
I'd already monkeypatched this in my own project in order to use a QA model, so here's a PR
happy to make any tweaks required