Skip to content

SPICE-0028: Add support for multi-line string line continuations#1507

Merged
HT154 merged 1 commit intoapple:mainfrom
HT154:string-multiline-continuation
Apr 21, 2026
Merged

SPICE-0028: Add support for multi-line string line continuations#1507
HT154 merged 1 commit intoapple:mainfrom
HT154:string-multiline-continuation

Conversation

@HT154
Copy link
Copy Markdown
Contributor

@HT154 HT154 commented Apr 7, 2026

@HT154 HT154 force-pushed the string-multiline-continuation branch from cfecef2 to a0f96db Compare April 8, 2026 00:21
@HT154 HT154 changed the title Add support for Swift-style multi-line string continuations SPICE-0028: Add support for Swift-style multi-line string continuations Apr 8, 2026
@HT154 HT154 changed the title SPICE-0028: Add support for Swift-style multi-line string continuations SPICE-0028: Add support for multi-line string line continuations Apr 9, 2026
@HT154 HT154 force-pushed the string-multiline-continuation branch 5 times, most recently from e3503d4 to 4ea2208 Compare April 14, 2026 22:25
Copy link
Copy Markdown
Member

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments.

Can we also add a parser error test for whitespace after line continuation?

Comment thread docs/modules/language-reference/pages/index.adoc Outdated
Comment thread pkl-core/src/test/files/LanguageSnippetTests/input/basic/stringMultiline.pkl Outdated
@HT154 HT154 force-pushed the string-multiline-continuation branch 2 times, most recently from 04410e3 to 4fdd089 Compare April 15, 2026 20:02
@HT154 HT154 requested a review from bioball April 15, 2026 20:03
Copy link
Copy Markdown
Member

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also looking for a thumb from @stackoverflow

Comment thread pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser21.err Outdated
@HT154 HT154 force-pushed the string-multiline-continuation branch 2 times, most recently from d4f7beb to 233f2e2 Compare April 16, 2026 21:32
Copy link
Copy Markdown
Contributor

@stackoverflow stackoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread pkl-formatter/src/main/java/org/pkl/formatter/Builder.java Outdated
@HT154 HT154 force-pushed the string-multiline-continuation branch from 233f2e2 to 37bc2c4 Compare April 21, 2026 17:04
@HT154 HT154 force-pushed the string-multiline-continuation branch from 37bc2c4 to 58dc3a7 Compare April 21, 2026 17:06
@HT154 HT154 merged commit e07abb7 into apple:main Apr 21, 2026
21 checks passed
@HT154 HT154 deleted the string-multiline-continuation branch April 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants