Fix pkl:test fact power assertions when member source section is unavailable#1571
Merged
HT154 merged 1 commit intoapple:mainfrom May 4, 2026
Conversation
bioball
approved these changes
May 4, 2026
HT154
force-pushed
the
test-facts-power-assertion-unavailable-source-section
branch
from
f0010b1 to
04bdbdb
Compare
HT154
commented
May 4, 2026
Comment on lines
+87
to
+89
| if (!sourceSection.isAvailable()) { | ||
| throw new PklBugException("Power assertions require an available source section"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Added this check to simplify debugging similar issues in the future.
Member
There was a problem hiding this comment.
Use an assertion here instead, e.g.
assert sourceSection.isAvailable() : "Power assertions require an available source section"Assertions are there for conditions that we guarantee to be true, and (ideally) surface via our tests. They get compiled away when we build our executable.
HT154
force-pushed
the
test-facts-power-assertion-unavailable-source-section
branch
from
04bdbdb to
1c2f586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Power assertions only work when the source section is available. If it is unavailable, power assertions throw a ParserError (unexpected EOF on an empty input) when re-parsing the expression for presentation.