Add SecretMarkingProvider for post-hoc secret marking #132
+514
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new wrapper provider that marks configuration values as secrets based on key patterns, useful when integrating with external providers that don't properly identify sensitive data. Changes: - Add SecretMarkingProvider wrapper - Add convenience methods: markSecrets(where:), markSecretsForKeys(_:) - Add comprehensive tests - Add proposal SCO-0004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SecretMarkingProvider- a wrapper that marks config values as secrets based on key patterns.Motivation
External config sources (env vars, third-party providers) don't always mark sensitive data properly. This lets you retroactively apply secret marking without writing a custom wrapper.
Changes
SecretMarkingProvider<Upstream>wrappermarkSecrets(where:),markSecretsForKeys(_:)Note
Based on your comment on #131, I can switch to
SecretsSpecifier<AbsoluteConfigKey, ConfigValue>instead of the custom predicate - let me know.Closes #131