-
Notifications
You must be signed in to change notification settings - Fork 14
Abstract API: add server transport capability request option #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nakulbajaj
wants to merge
5
commits into
apple:main
Choose a base branch
from
nakulbajaj:request-options-server-http-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b49d7a5
Abstract API: add server HTTP version request option
nakulbajaj 8a363cf
Transport version hint instead of HTTP version
nakulbajaj dc10492
format fixes
nakulbajaj 0fed93e
addressing feedback (renaming protocol + property)
nakulbajaj 535c406
add TCP as default for URLSession serverSupportedTransportsHint
nakulbajaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
Sources/HTTPAPIs/Client/HTTPClientCapability+ServerTransportHint.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift HTTP API Proposal open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift HTTP API Proposal project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| public import NetworkTypes | ||
|
|
||
| @available(macOS 26.2, iOS 26.2, watchOS 26.2, tvOS 26.2, visionOS 26.2, *) | ||
| extension HTTPClientCapability { | ||
| /// A protocol for HTTP request options that hint at the transports a | ||
| /// server is known to support. | ||
| /// | ||
| /// Providing server transport information allows the client to optimize | ||
| /// connection establishment. For example, if a server is known to support | ||
| /// QUIC, the client can attempt an HTTP/3 connection directly instead of | ||
| /// falling back to TCP-based negotiation. | ||
| public protocol ServerTransportHint: RequestOptions { | ||
| /// The transports that the target server is known to support. | ||
| /// | ||
| /// An empty set indicates no prior knowledge of server capabilities, | ||
| /// and the client uses its default protocol negotiation behavior. | ||
| var serverSupportedTransportsHint: Set<HTTPTransportVersion> { get set } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift HTTP API Proposal open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift HTTP API Proposal project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// An enumeration that represents a transport protocol used to carry HTTP | ||
| /// traffic. | ||
| /// | ||
| /// ``HTTPTransportVersion`` provides type-safe access to supported transport | ||
| /// protocols, allowing clients and servers to communicate transport | ||
| /// capabilities. New transports may be added in future releases, so client | ||
| /// code must handle unknown cases. | ||
| @nonexhaustive | ||
| public enum HTTPTransportVersion: Sendable, Hashable { | ||
| /// TCP transport. | ||
| /// | ||
| /// Whether TLS is layered on top is determined by the request's URL | ||
| /// scheme (`http` vs. `https`). | ||
| case tcp | ||
|
|
||
| /// QUIC transport. | ||
| /// | ||
| /// QUIC is defined in RFC 9000 and is the transport used by HTTP/3 | ||
| /// (RFC 9114). | ||
| case quic | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should AHC conform or should we keep it to URLSession? Also let's make this
.tcpby default as well