Skip to content

[SYS-0007] Add overloads to cover dup3 and pipe2 POSIX APIs#303

Open
glessard wants to merge 8 commits into
release/1.7.0from
dup3-pipe2
Open

[SYS-0007] Add overloads to cover dup3 and pipe2 POSIX APIs#303
glessard wants to merge 8 commits into
release/1.7.0from
dup3-pipe2

Conversation

@glessard
Copy link
Copy Markdown
Contributor

jakepetroules and others added 6 commits May 20, 2026 09:58
This follows the existing pattern of wrapping dup/dup2 and pipe with FileDescriptor.duplicate and FileDescriptor.pipe, with additional overloads for passing the O_CLOEXEC and similar flags.
@glessard glessard requested review from jrflat, lorentey and milseman and removed request for lorentey and milseman May 26, 2026 23:26
@glessard glessard changed the base branch from release/1.7.0 to main May 27, 2026 00:14
@glessard glessard changed the base branch from main to release/1.7.0 May 27, 2026 00:15
Comment thread Sources/CSystem/CMakeLists.txt Outdated
@jrflat
Copy link
Copy Markdown
Contributor

jrflat commented May 29, 2026

@swift-ci please test

Copy link
Copy Markdown
Contributor Author

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrflat
Copy link
Copy Markdown
Contributor

jrflat commented May 29, 2026

Kicked off another Windows toolchain build to verify all's good in the CI. Linux failure on this PR looks strange:

12:50:27  + docker pull swiftlang/swift:nightly-1.7.0-jammy
12:50:28  Error response from daemon: manifest for swiftlang/swift:nightly-1.7.0-jammy not found: manifest unknown: manifest

Looks like it's parsing the System release/1.7.0 branch as the nightly swift version?

@glessard
Copy link
Copy Markdown
Contributor Author

Yeah, we shouldn't ask "please test" for destination branches other than "main", apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants