Fix typos, modernize os(OSX) → os(macOS), and clean up Notification.Name bridging in XCPlayground#80
Open
crleonard wants to merge 4 commits into
Open
Conversation
Two error strings in PlaygroundQuickLook+OpaqueRepresentationSupport.swift contained "is is" instead of "it is". These strings surface in Xcode's playground results panel.
CaptureValueTests.swift had a misspelled MARK label.
Replace '"string" as NSString as NSNotification.Name' with 'Notification.Name(rawValue: "string")' across all four notification posts, consistent with how PlaygroundPage.swift already constructs them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of small, low-risk housekeeping fixes across PlaygroundLogger and PlaygroundSupport.
Changes
Bug fixes
PlaygroundQuickLook+OpaqueRepresentationSupport.swiftthat read "is is" instead of "it is" (lines 106 and 116). These strings surface in Xcode's playground results panel.
Typo fix
// MARK: Deprected XCPlaygroundPageinCaptureValueTests.swift.Modernization
Replace
os(OSX)withos(macOS)inXCPlaygroundPage.swiftandXCPShowView.swift(5 occurrences).Replace
"string" as NSString as NSNotification.NamewithNotification.Name(rawValue: "string")across the four notification postsin
XCPlaygroundPage.swift. The double-bridge cast is unnecessary;PlaygroundPage.swiftalready uses the correct form.Testing
All existing tests pass:
PlaygroundLogger (macOS): 44 tests, 0 failuresXCPlayground (macOS): 6 tests, 0 failures