docs: 하네스 감사 — credential file-only 반영 + 커버 범위·톤 정합#189
Merged
Conversation
- Credential storage 섹션을 #179 이후 실제 구현(file-only)에 맞게 재작성: keychain 3-platform 상세 제거, PASSWORD=credentials.json 0600, source priority env→file, keychain migration 한 줄 언급 - 커버 범위에 keys create/ls/revoke (Deploy Key) 및 members ls/invite/remove 추가 - '공식 프로젝트 아님.' 방어적 라벨 삭제 (umbrella §2.1) - umbrella CLAUDE.md 참조를 GitHub 절대 URL로 변경 (umbrella §7) Closes #188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
하네스 감사 follow-up으로
CLAUDE.md정합 문제 4건 수정. 코드 변경 없음.FILE_BACKEND = src/auth/backends/file.js,~/.config/aitcc/credentials.jsonmode 0600, source priority env→file)에 맞게 재작성. keychain → file migration 함수(migrateKeychainToFileIfNeeded)는 한 줄로만 언급.keys create/ls/revoke(Deploy Key),members ls/invite/remove공식 프로젝트 아님.제거 (umbrella CLAUDE.md §2.1 준수)Test plan
src/auth/credentials.ts구현과 일치하는지 확인https://github.com/apps-in-toss-community/umbrella/blob/main/CLAUDE.md) 유효성 확인Closes #188