Add logic to Sidekiq for ActiveJob log_arguments#1504
Merged
tombruijn merged 1 commit intorespect-activejob-log-arguments-tomfrom Apr 7, 2026
Merged
Conversation
When a customer Configures ActiveJob `log_arguments` to be false, it would not adhere to this in the other integrations like Sidekiq, DelayedJob, etc. Implemented this logic in Sidekiq so that it doesn't set the parameters if they're unset on ActiveJob.
tombruijn
changed the base branch from
respect-activejob-log-arguments
to
respect-activejob-log-arguments-tom
tombruijn
force-pushed
the
respect-activejob-log-arguments-per-library
branch
from
dcb0af0 to
ce1ddd3
Compare
tombruijn
commented
Mar 31, 2026
| if transaction | ||
| transaction.add_params_if_nil { parse_arguments(item) } | ||
| # If ActiveJob log_arguments is set to false, don't set params | ||
| store_arguments = transaction.store("activejob").fetch("log_arguments", true) |
Member
Author
There was a problem hiding this comment.
I don't necessarily love this system but it already exists in the Ruby gem so I tried making it work with this first.
Member
Author
|
@unflxw @lipskis What do you think of this as a solution to the problem I pointed out in the other PR? We have to implement this logic for every library that is compatible with ActiveJob. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tombruijn
merged commit 51151a9
into
respect-activejob-log-arguments-tom
195 checks passed
This is a message from the daily scheduled checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a customer Configures ActiveJob
log_argumentsto be false, it would not adhere to this in the other integrations like Sidekiq, DelayedJob, etc.Implemented this logic in Sidekiq so that it doesn't set the parameters if they're unset on ActiveJob.
Based on #1499 and #1507