Skip to content

Add codex plugin#1482

Open
adityaoberai wants to merge 15 commits intomasterfrom
codex-plugin
Open

Add codex plugin#1482
adityaoberai wants to merge 15 commits intomasterfrom
codex-plugin

Conversation

@adityaoberai
Copy link
Copy Markdown
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

  • Adds a new CodexPlugin that generates Codex CLI plugin assets (skills, plugin/marketplace manifests, MCP config, README/LICENSE) by reusing agent-skills/ templates directly — avoiding the skill-name frontmatter mismatch that earlier iterations had.
  • cursor-plugin/LICENSE.twig is changed from MIT to BSD-3-Clause; codex-plugin/plugin.json.twig and claude-plugin/README.md.twig are updated accordingly, but claude-plugin/plugin.json.twig still hardcodes \"MIT\" — producing a mismatch between the generated LICENSE file and the plugin manifest for the Claude plugin.
  • Previously flagged path issues in plugin.json.twig (../skills/, ../.mcp.json) and marketplace.json.twig (../../plugins/appwrite) are now resolved correctly.

Confidence Score: 4/5

Safe to merge after fixing the hardcoded MIT license in claude-plugin/plugin.json.twig.

One P1 finding: claude-plugin/plugin.json.twig declares "license": "MIT" while the BSD-3-Clause change to cursor-plugin/LICENSE.twig (part of this PR) means the generated LICENSE file will be BSD-3-Clause. All other previously flagged path and license issues in the Codex plugin templates appear resolved.

templates/claude-plugin/plugin.json.twig — hardcoded MIT license contradicts the updated LICENSE template.

Important Files Changed

Filename Overview
src/SDK/Language/CodexPlugin.php New plugin class that generates skills, plugin manifest, marketplace manifest, MCP config, and README. Paths and template references look correct.
templates/codex-plugin/plugin.json.twig Plugin manifest with correct relative paths (../skills/, ../.mcp.json), templated repository and license fields.
templates/codex-plugin/marketplace.json.twig Marketplace manifest placed at .agents/plugins/marketplace.json; path ../../plugins/appwrite correctly resolves to the plugin root from that location.
templates/cursor-plugin/LICENSE.twig Changed from MIT to BSD-3-Clause; used by CursorPlugin, ClaudePlugin, and CodexPlugin. claude-plugin/plugin.json.twig and claude-plugin/marketplace.json.twig still declare "MIT", creating a metadata mismatch.
templates/claude-plugin/plugin.json.twig Hardcoded "license": "MIT" contradicts the BSD-3-Clause LICENSE file now generated from the updated cursor-plugin/LICENSE.twig.
templates/codex-plugin/skills/deploy-function.md.twig Full deployment workflow skill with correct CLI commands; all management and variable commands include required ID flags.
templates/codex-plugin/skills/deploy-site.md.twig Site deployment skill; delete-variable command is missing --variable-id (flagged in a previous review thread).
templates/codex-plugin/README.md.twig README with correct install paths referencing plugins/appwrite/ prefix; license link uses templated variables.
templates/codex-plugin/.mcp.json.twig MCP server config using direct HTTP transport; consistent with plugin-install flow (manual installs use config.toml with npx mcp-remote).
templates/codex-plugin/config.toml.twig TOML snippet for manual installs, using npx mcp-remote stdio transport; correct and consistent with README instructions.

Comments Outside Diff (1)

  1. templates/claude-plugin/plugin.json.twig, line 11 (link)

    P1 This PR changes cursor-plugin/LICENSE.twig to BSD-3-Clause, and ClaudePlugin.php uses that template for the generated LICENSE file. The claude-plugin/plugin.json.twig manifest still declares "MIT", so the generated plugin repo will carry a BSD-3-Clause LICENSE file that contradicts the manifest metadata. The sibling codex-plugin/plugin.json.twig already uses {{ spec.licenseName }} correctly.

Reviews (13): Last reviewed commit: "Update templates/codex-plugin/marketplac..." | Re-trigger Greptile

Comment thread templates/codex-plugin/skills/deploy-site.md.twig Outdated
Comment thread templates/codex-plugin/plugin.json.twig Outdated
Comment thread templates/codex-plugin/skills/cli.md.twig Outdated
adityaoberai and others added 4 commits April 28, 2026 21:46
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Comment thread templates/codex-plugin/skills/cli.md.twig Outdated
Comment thread templates/codex-plugin/plugin.json.twig Outdated
Comment thread templates/codex-plugin/marketplace.json.twig
Comment thread templates/codex-plugin/plugin.json.twig Outdated
Comment thread templates/codex-plugin/README.md.twig
adityaoberai and others added 3 commits April 30, 2026 02:20
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Comment thread templates/codex-plugin/marketplace.json.twig
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@@ -1,21 +1,12 @@
MIT License
Copyright (c) 2026 Appwrite (https://appwrite.io) and individual contributors.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we change license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants