Outer builder container: agent-server + rootless podman image#3
Open
alexanderkreidich wants to merge 7 commits into
Open
Outer builder container: agent-server + rootless podman image#3alexanderkreidich wants to merge 7 commits into
alexanderkreidich wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Implements items 1, 2 and 4 of builder-container-architecture.md's 'What Needs to Be Built': the Dockerfile, the canonical run script (spawn contract for orchestrators), and the builder system prompt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Verified on Ubuntu noble (arm64): --cap-add SYS_ADMIN for newuidmap, --device /dev/net/tun for slirp4netns, systempaths=unconfined for crun sysctl writes. All verify.sh acceptance checks pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95d5e0e02b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Builder images copied AGENTS.builder.md under /home/builder/.pi/agent, but ProjectRegistry passes /workspace/.pi-global as the runtime agentDir. New projects without their own .pi/AGENTS.md therefore could start without the podman, port, and secret-handling instructions required by the builder container. Bake the prompt as an image template and have the entrypoint install it into WORKSPACE_DIR/.pi-global/AGENTS.md when the mounted workspace does not already provide one. Update the Docker docs to describe the actual lookup path and the project-local override behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builder-container-architecture.md's "What Needs to Be Built": the outer containerDockerfile(Ubuntu 24.04 + NodeSource 22 + rootless podman with fuse-overlayfs, non-rootbuilderuser with subuid/subgid ranges), the canonical spawn contractdocker/builder/run.sh, and the builder system promptAGENTS.builder.mdbaked as an image template and installed at${WORKSPACE_DIR}/.pi-global/AGENTS.mdon startup.run.shruns the container without--privileged:--device /dev/fuse --device /dev/net/tun --cap-add SYS_ADMIN --security-opt seccomp/apparmor/systempaths=unconfined, named volumes for/workspaceand podman storage, ports4001+3000-3010, provider keys via-e. Each flag is documented in-line with the failure it fixes; a tailored seccomp profile is a named hardening follow-up.docker/builder/verify.shis the acceptance suite; design + verification record live indocs/superpowers/specs/2026-06-10-outer-builder-container-design.md. Architecture doc and README updated.Test Plan
Verified on a clean Ubuntu noble arm64 VM (OrbStack) with Docker 29 — all checks pass:
/v1/healthz, idempotentPOST /v1/projects, session createpodman run alpineinside the container):3000reachable from the host — the full host → outer → inner port chainpodman run -d --name demo-live-app -p 3000:80 nginx:alpine; the page is reachable from the VM and from the macOS host (http://appx-builder-vm.orb.local:3000)Additional verification for the prompt-path fix:
npm run buildnpm testnpx biome check . --error-on-warningsdocker build -f docker/builder/Dockerfile -t appx-agent-server-builder-prompt-test ./workspace/.pi-global/AGENTS.mdexists and matches/usr/local/share/appx-builder/AGENTS.md🤖 Generated with Claude Code