Bugfix: append traceback to existing output for errored runs#478
Open
LudovicoRighi wants to merge 3 commits intomainfrom
Open
Bugfix: append traceback to existing output for errored runs#478LudovicoRighi wants to merge 3 commits intomainfrom
LudovicoRighi wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related note:
apsis/python/apsis/apsis.py
Lines 339 to 340 in e5f1029
Tested this for:
runs that produce output
runs that don't produce any output
UPDATE: need to review this again; we probably shouldn't mix output and Apsis errors.