Fixing tests #381
Open
Fixing tests #381
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 28
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if "maxSkewThreshold" in body: | ||
| result["max_skew_threshold"] = body["maxSkewThreshold"] | ||
| if "minDeletionRatio" in body: | ||
| result["min_deletion_ratio"] = body["minDeletionRatio"] |
There was a problem hiding this comment.
Bug: Possible consolidation policy field name mismatch
The new mappings rely on ArangoDB returning consolidation policy keys exactly as maxSkewThreshold and minDeletionRatio. If the server uses different casing or different attribute names for these options in the targeted “latest version”, format_view_consolidation_policy silently drops them and callers won’t see these settings in formatted output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update needed for latest version
Note
Add support for
maxSkewThresholdandminDeletionRatioinformat_view_consolidation_policy, mapping tomax_skew_thresholdandmin_deletion_ratio.format_view_consolidation_policyto map:maxSkewThreshold->max_skew_thresholdminDeletionRatio->min_deletion_ratioWritten by Cursor Bugbot for commit 8257d21. This will update automatically on new commits. Configure here.