Lvm2/LUKS fixes/Mirror Logic #4047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I might actually have introduced the new bug when using Please feel free to test as-well I'll mark the PR as open/ready for review. But obviously this should be addressed further. |
Torxed
requested changes
Dec 29, 2025
archinstall/lib/mirrors.py
Outdated
| # original return | ||
| return sorted(region_list, key=lambda mirror: (mirror.score, mirror.speed)) | ||
| # Sort by speed descending (higher is better) - fastest mirrors first | ||
| return sorted(region_list, key=lambda mirror: -mirror.speed) |
Member
There was a problem hiding this comment.
Could we move this to a separate PR? Just to not fix two things in one, in case one needs to be reverted :)
Contributor
Author
There was a problem hiding this comment.
Sry bout that was frustrated at mirrors when testing
Torxed
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address #4045 #4046
I then did sanity check with 3rd attempt without encryption same settings LVM BTRFS, and got "signature exists" errors (this why i tried the
wipefscall).(That being said/done) For real clean-ups we should have kind of like traps in bash (especially test this running from a host, since you'd need to check the devices are not still there
/dev/ArchinstallVg/root(which i believe they are, from earlier testing my main rig) And should really happen at the very end (even after synchronizing disks).Tested LVM against both of these and without encryption