Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
davidmytton
left a comment
davidmytton
left a comment
There was a problem hiding this comment.
Good to document these! Some suggestions for improving the PR.
wooorm-arcjet
force-pushed
the
wooorm/concept-env-variables
branch
from
a6ae46b to
4a3bc85
Compare
qw-in
left a comment
qw-in
left a comment
There was a problem hiding this comment.
Couple comments between meetings
src/content/docs/troubleshooting.mdx
Outdated
|
|
||
| const aj = arcjet({ | ||
| // Get your site key from https://app.arcjet.com | ||
| // Your Arcjet Cloud API key <https://docs.arcjet.com/concepts/environment#arcjet-key>. |
There was a problem hiding this comment.
| // Your Arcjet Cloud API key <https://docs.arcjet.com/concepts/environment#arcjet-key>. | |
| // Your Arcjet key <https://docs.arcjet.com/concepts/environment#arcjet-key>. |
There was a problem hiding this comment.
I have a couple of nit-y comments but overall think this is a great change with lots of good and helpful information! Thanks
(#717 went in so I expect those tests may fail against this branch. Good test of how much friction/pain vs value the tests add tho)
davidmytton
left a comment
davidmytton
left a comment
There was a problem hiding this comment.
I've moved the platform vars into their own section and also put this into the advanced section under the sidebar. We might want to reorganize this later,but I'd like to have more sections in Concepts. We can do that later.
Related-to: GH-704. Related-to: ENG-127.
Co-authored-by: Quinn Blenkinsop <quinn@arcjet.com>
Co-authored-by: Quinn Blenkinsop <quinn@arcjet.com>
wooorm-arcjet
force-pushed
the
wooorm/concept-env-variables
branch
from
0503f32 to
57ff62d
Compare
Co-authored-by: Titus <titus@arcjet.com>
|
yay! Thanks all! |
3 participants
Related-to: GH-704.
Related-to: ENG-127.