Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

Conversation

@Stolb27
Copy link

@Stolb27 Stolb27 commented Sep 18, 2025

Cleanup never terminates helper processes

The problem is caused by additional grep command that was introduced in
4bfd4c0. Expressions starting with -- should be escaped properly to
returns anything. The command pipeline is failed with:

grep: unrecognized option '--pipe-file

on stderr and empty stdout. As a result, process cleanup do nothing.

This patch add expression separators for grep command.

Ticket: ADBDEV-8304

The problem is caused by additional grep command that was introduced in
4bfd4c0. Expressions starting with -- should be escaped properly to
returns anything. The command pipeline is failed with:

> grep: unrecognized option '--pipe-file

on stderr and empty stdout. As a result, process cleanup do nothing.

This patch add expression separators for grep command.

Ticket: ADBDEV-8304
@RekGRpth

This comment was marked as resolved.

@Stolb27
Copy link
Author

Stolb27 commented Sep 19, 2025

To ensure that the test from commit 4bfd4c0 fails without your patch, you need to add an error check to the CheckHelperPids function, as is done in the similar GetHelperFileCount function.

In my opinion, it's a separate problem to implement exit-code handling.

@Stolb27 Stolb27 merged commit a854df4 into master Sep 22, 2025
2 checks passed
@Stolb27 Stolb27 deleted the ADBDEV-8304 branch September 22, 2025 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants