feat(github): Add checkrun support#223
Open
davhdavh wants to merge 28 commits intoargoproj:masterfrom
Open
Conversation
davhdavh
commented
Sep 28, 2023
- Cleans up the github code so that each new template-supported prop only takes a single line (instead of 10+)
- Add support for CheckRuns
- Add a bit of documentation for all of the supported APIs
15aa525 to
b49553d
Compare
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
b2ac62c to
4ba5076
Compare
Signed-off-by: Dennis Haney <davh@davh.dk>
Author
|
That linter is really annoying, could it not just give ALL of the errors in 1 run, instead of taking 8... anyway, how to solve the last one? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 55.13% 54.74% -0.40%
==========================================
Files 35 35
Lines 3337 3352 +15
==========================================
- Hits 1840 1835 -5
- Misses 1230 1263 +33
+ Partials 267 254 -13
☔ View full report in Codecov by Sentry. |
Signed-off-by: Dennis Haney <davh@davh.dk>
Author
|
There is no existing tests for the api calls, so I have no idea how to make test for the new api call. |
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
Signed-off-by: Dennis Haney <davh@davh.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.