[Draft] Update awssqs.go with extra logging before calling AWS SDK.#347
Open
viv-ng wants to merge 5 commits intoargoproj:masterfrom
Open
[Draft] Update awssqs.go with extra logging before calling AWS SDK.#347viv-ng wants to merge 5 commits intoargoproj:masterfrom
viv-ng wants to merge 5 commits intoargoproj:masterfrom
Conversation
viv-ng
commented
Nov 25, 2024
viv-ng
commented
- Added more logging to see what input we are calling AWS methods with.
- Added some comment.
viv-ng
force-pushed
the
viv-ng-aws-logging
branch
2 times, most recently
from
2103945 to
2d57c71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 55.35% 56.14% +0.79%
==========================================
Files 35 35
Lines 3438 3644 +206
==========================================
+ Hits 1903 2046 +143
- Misses 1256 1293 +37
- Partials 279 305 +26 ☔ View full report in Codecov by Sentry. |
…Message(). Added more logging to see what input we are calling AWS methods with. Signed-off-by: Vivien Ng <vivienn@zillowgroup.com>
Signed-off-by: Vivien Ng <vivienn@zillowgroup.com>
Signed-off-by: Vivien Ng <vivienn@zillowgroup.com>
Signed-off-by: Vivien Ng <vivienn@zillowgroup.com>
viv-ng
force-pushed
the
viv-ng-aws-logging
branch
from
912ef48 to
8beb552
Compare
Signed-off-by: Vivien Ng <vivienn@zillowgroup.com>
pasha-codefresh
requested changes
Jan 25, 2026
| if input.QueueOwnerAWSAccountId != nil { | ||
| accountIdStr = ", account_id: " + *input.QueueOwnerAWSAccountId | ||
| } | ||
| log.Infof("[GetQueueUrl] queue_name: %s%s", *input.QueueName, accountIdStr) |
Member
There was a problem hiding this comment.
why not to paste account_id as part of template, why you need to build string separately?
| return err | ||
| } | ||
|
|
||
| // 'sendMessageInput()' provides queueUrl, message |
Member
There was a problem hiding this comment.
I would not write such comments, code itself selfdescriptive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.