Fix mixin crash with litematica 0.28.3 (MC 26.2)#113
Open
naari3 wants to merge 1 commit into
Open
Conversation
litematica 0.28.3 (MC 26.2) refactored GPU buffer handling into ChunkRenderDispatcherBuffers, which changed the signature of ChunkRendererSchematicVbo.renderBlocksAndOverlay: a ChunkRenderDispatcherBuffers parameter is now inserted between ChunkMeshDataSchematic and IBlockOutputSchematic. The mixin in ChunkRendererSchematicVboMixin captured the old argument list, so the injector no longer matched the target descriptor and mixin application failed with an InvalidInjectionException, crashing on world join. Add the new parameter to the injector handler and bump the 26.2 dependencies to litematica 0.28.3 and malilib 0.29.3. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
litematica 0.28.3 added a
ChunkRenderDispatcherBuffersparameter toChunkRendererSchematicVbo.renderBlocksAndOverlay(...), so the injector inChunkRendererSchematicVboMixinno longer matched and mixin application failed with anInvalidInjectionException(crash on world join).