Skip to content

fix: remove cursor position checks from history navigation keys #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ariane-emory wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

fix: remove cursor position checks from history navigation keys #237

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c216e15
fix: remove cursor position checks from history navigation keys
ariane-emory Mar 9, 2026
b715fa2
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Mar 13, 2026
0333989
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Mar 20, 2026
01762bf
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Mar 20, 2026
eaf09a8
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Mar 24, 2026
2bbbcc1
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Mar 24, 2026
32d32a7
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Mar 24, 2026
4fa3d4b
Merge branch 'dev' into fix/history-navigation-key-commands
ariane-emory Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,10 +972,7 @@ export function Prompt(props: PromptProps) {
}
if (store.mode === "normal") autocomplete.onKeyDown(e)
if (!autocomplete.visible) {
if (
(keybind.match("history_previous", e) && input.cursorOffset === 0) ||
(keybind.match("history_next", e) && input.cursorOffset === input.plainText.length)
) {
if (keybind.match("history_previous", e) || keybind.match("history_next", e)) {
const direction = keybind.match("history_previous", e) ? -1 : 1
const item = history.move(direction, input.plainText)

Expand All @@ -985,15 +982,10 @@ export function Prompt(props: PromptProps) {
setStore("mode", item.mode ?? "normal")
restoreExtmarksFromParts(item.parts)
e.preventDefault()
if (direction === -1) input.cursorOffset = 0
if (direction === 1) input.cursorOffset = input.plainText.length
input.cursorOffset = input.plainText.length
}
return
}

if (keybind.match("history_previous", e) && input.visualCursor.visualRow === 0) input.cursorOffset = 0
if (keybind.match("history_next", e) && input.visualCursor.visualRow === input.height - 1)
input.cursorOffset = input.plainText.length
}
}}
onSubmit={submit}
Expand Down