Add an Absorb trait bound to PCCommitment#144
Open
mmagician wants to merge 6 commits intoarkworks-rs:masterfrom
Open
Add an Absorb trait bound to PCCommitment#144mmagician wants to merge 6 commits intoarkworks-rs:masterfrom
Absorb trait bound to PCCommitment#144mmagician wants to merge 6 commits intoarkworks-rs:masterfrom
Conversation
mmagician
requested review from
Pratyush,
weikengchen and
z-tech
and removed request for
a team
mmagician
commented
Feb 6, 2024
Pratyush
reviewed
Feb 8, 2024
Comment on lines
+328
to
+334
| pub struct Commitment<E>( | ||
| /// The commitment is a group element. | ||
| pub E::G1Affine, | ||
| ); | ||
| ) | ||
| where | ||
| E: Pairing, | ||
| E::G1Affine: Absorb; |
Member
There was a problem hiding this comment.
Technically, we don't need an Absorb bound on E::G1Affine, only on the PCCommitment impl and on the Absorb impl, right?
Member
There was a problem hiding this comment.
That would avoid most of this churn I think
Member
Author
There was a problem hiding this comment.
If I restrict PCCommitment: Absorb, then I also have to ensure any struct which implements PCCommitment also implements Absorb - and so I need to restrict E::G1Affine etc. to also be Absorb.
Let me know if you have another idea for this, I currently can't see a better workaround.
mmagician
commented
Feb 9, 2024
| } | ||
|
|
||
| /// A commitment along with information about its degree bound (if any). | ||
| #[derive(Clone)] |
Member
Author
There was a problem hiding this comment.
@Pratyush If I'm not deriving Absorb, what about the degree_bound? I would assume this doesn't need to get absorbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following Option 2 from #143.
closes: #143
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer