First commit#1
Open
luciodale wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render-fnis great, but needed some extra capabilities to truly be general-purpose.In short, you can use an additional
:render-onlyto specify in a set what are the operations i.e. filter and sort that should rely on the raw data rather than the rendered one.the table can't rework the data on
component-did-mount, unfortunately. If we do that, then any update to rows or columns won't trigger any re-rerender.I removed the link-href logic on the row. You MIGHT want to add it back.
Added manual dark mode. For auto one I'll have to update the css as well. We can do that later.