Open
Conversation
jukebox/storage.py
Outdated
Owner
There was a problem hiding this comment.
This is making all kinds of blocking calls in the event loop.
Author
There was a problem hiding this comment.
figured it was ok cause its basicly in init but probably needs to be defferd to thread
Moving open command to the Song since GoogleMusicSong is opened differently then FileSongs
c46f428 to
f47b4f4
Compare
Author
|
Made some changes still need to fix tests and add get_uri that returns a differed but a good start . |
jukebox/song.py
Outdated
Author
|
Now with less blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Using gmusicapi Jukebox now supports the use of GoogleMusic accounts.
Adding a new GooglePlayStorage('username', 'password')
What is still to do:
Add MultipleStorage to access multiple users accounts as well as local accounts.
Have a smarter Authentication layer when the session expires.